[LIVOX MID 360][CALIBRATION]: Adding calibration and filter to livox lidar MID 360 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadaroce
suggested changes
Aug 15, 2023
| @@ -495,6 +501,71 @@ void Lddc::InitImuMsg(const ImuData& imu_data, ImuMsg& imu_msg, uint64_t& timest | |||
| imu_msg.linear_acceleration.z = imu_data.acc_z; | |||
| } | |||
|
|
|||
| void Lddc::StoreAccelerationValues(ImuMsg& imu_msg) { | |||
|
|
|||
| _imu_accel_x_vector.push_back(imu_msg.linear_acceleration.x); | |||
There was a problem hiding this comment.
Instead of push_back use emplace_back for a better performance use
pepisg
requested changes
Aug 17, 2023
Comment on lines
+537
to
+538
| std::cout << "ROLL: " << livox_roll*57.2958 << std::endl; | ||
| std::cout << "PITCH: " << livox_pitch*57.2958 << std::endl; |
There was a problem hiding this comment.
this logs shouldn't be necessary anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name: [LIVOX MID 360][CALIBRATION]: Adding calibration and filter to livox lidar MID 360
Basic Info
Main Objective of this PR: Adding a component in the launch to use the Box_crop filter from pcl_ros and also adding necessary stuff to make a calibration process using the livox lidar imu.
Issue this PR addresses: NA
Kiwibot fleet tested on: ANY
PR submission date: 2/08/2023