upgraded thanos components to v0.4.0 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Szilard Kovacs <kovszilard@gmail.com>
kovszilard
force-pushed
the
upgrade-thanos-4
branch
from
6a7d07c
to
6c80fcd
Compare
rpahli
requested changes
May 8, 2019
There was a problem hiding this comment.
Hi @kovszilard thanks for your PR ... can you please also change the README
Hi @rpahli, I just changed the readme |
Signed-off-by: Szilard Kovacs <kovszilard@gmail.com>
kovszilard
force-pushed
the
upgrade-thanos-4
branch
from
458ee06
to
c6e725f
Compare
axdotl
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
ThanosCompactor v0.4.0 has changed the flag
--sync-delayto--consistency-delayWhich issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]