Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove additionalDependencies for javadocs from the release profile #286

Closed
sleberknight opened this issue Oct 11, 2023 · 0 comments · Fixed by #287
Closed

Remove additionalDependencies for javadocs from the release profile #286

sleberknight opened this issue Oct 11, 2023 · 0 comments · Fixed by #287
Assignees
@sleberknight
Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools
Milestone
1.1.1

Comments

@sleberknight
Copy link
Member

Remove the <additionalDependencies /> section from the javadoc plugin in the POM. In #283 we switched Immutables to only use Jakarta Annotations, and also added jakarta.annotation:jakarta.annotation-api to the POM as a compile-scope dependency.

Refer to #284 for background.
@sleberknight sleberknight added the code cleanup Fix issues reported by Sonar or any other code analysis tools label Oct 11, 2023
@sleberknight sleberknight added this to the 1.1.1 milestone Oct 11, 2023
@sleberknight sleberknight self-assigned this Oct 11, 2023
sleberknight added a commit that referenced this issue Oct 11, 2023
@sleberknight
Remove additionalDependencies for javadocs from the release profile
4e948c5 
* Remove the javax and jakarta "additional" dependencies from the
  javadoc plugin; not needed anymore
* Remove the comment in the POM which referencd adding the
  (javax) annotation-api as an additional dependency, again since
  no longer relevant

Closes #286
@sleberknight sleberknight mentioned this issue Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools
Projects
None yet
Milestone
1.1.1
Development

Successfully merging a pull request may close this issue.

Remove additionalDependencies for javadocs from the release profile kiwiproject/consul-client
1 participant
@sleberknight