Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate usage of the "options" constants ⚠ #356

Closed
sleberknight opened this issue Jun 3, 2024 · 0 comments · Fixed by #360
Closed

Deprecate usage of the "options" constants ⚠ #356

sleberknight opened this issue Jun 3, 2024 · 0 comments · Fixed by #360
Assignees
@sleberknight
Labels
deprecation Deprecates an existing feature
Milestone
1.3.3

Comments

@sleberknight
Copy link
Member

sleberknight commented Jun 3, 2024 •
edited
Loading

Deprecate the constant fields in the "options" classes, for removal:

  • DeleteOptions.BLANK
  • DeleteOptions.RECURSE
  • EventOptions.BLANK
  • PutOptions.BLANK
  • QueryOptions.BLANK
  • QueryParameterOptions.BLANK
  • RoleOptions.BLANK
  • TokenQueryOptions.BLANK
  • TransactionOptions.BLANK

In a later version, we will add the replacements and update the deprecation annotations.
@sleberknight sleberknight added the deprecation Deprecates an existing feature label Jun 3, 2024
@sleberknight sleberknight added this to the 1.3.3 milestone Jun 3, 2024
@sleberknight sleberknight self-assigned this Jun 3, 2024
This was referenced Jun 3, 2024
Closed
Open
Closed
@sleberknight sleberknight changed the title Deprecate usage of the "options" constants Deprecate usage of the "options" constants ⚠ Jun 3, 2024
@sleberknight sleberknight mentioned this issue Jun 3, 2024
Closed
sleberknight added a commit that referenced this issue Jun 3, 2024
@sleberknight
Deprecate usage of the "options" constants for removal
c87596e 
We don't yet have the replacements as of 1.3.3. Those will
be added in 1.4.0.

Closes #356
@sleberknight sleberknight mentioned this issue Jun 3, 2024
Merged
sleberknight added a commit that referenced this issue Jun 3, 2024
@sleberknight
Deprecate usage of the "options" constants for removal (#360)
2ffc365 
We don't yet have the replacements as of 1.3.3. Those will
be added in 1.4.0.

Closes #356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
deprecation Deprecates an existing feature
Projects
None yet
Milestone
1.3.3
Development

Successfully merging a pull request may close this issue.

Deprecate usage of the "options" constants for removal kiwiproject/consul-client
1 participant
@sleberknight