Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: extract Lists util class from duplicate code #382

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Cleanup: extract Lists util class from duplicate code #382

merged 1 commit into from
Oct 10, 2024

Conversation

sleberknight
Copy link
Member

  • Add Lists class with firstValueOrEmpty and isNullOrEmpty
  • Update KeyValueClient and SessionClient to use Lists class
  • Change awkward assertions in CoordinateClientITest to use isNotNull

@sleberknight
Cleanup: extract Lists util class from duplicate code
15b1770 
* Add Lists class with firstValueOrEmpty and isNullOrEmpty
* Update KeyValueClient and SessionClient to use Lists class
* Change awkward assertions in CoordinateClientITest to use isNotNull
@sleberknight sleberknight added the code cleanup Fix issues reported by Sonar or any other code analysis tools label Oct 10, 2024
@sleberknight sleberknight added this to the 1.4.2 milestone Oct 10, 2024
@sleberknight sleberknight self-assigned this Oct 10, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sleberknight sleberknight merged commit fb6adc2 into main Oct 10, 2024
5 checks passed
@sleberknight sleberknight deleted the extract-Lists-util-class branch October 10, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sleberknight sleberknight

Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools
Projects
None yet
Milestone
1.4.2
Development

Successfully merging this pull request may close these issues.
1 participant
@sleberknight