Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support disableSniHostCheck in TlsConfigProvider #250

Closed
sleberknight opened this issue Nov 22, 2023 · 0 comments · Fixed by #256
Closed

Support disableSniHostCheck in TlsConfigProvider #250

sleberknight opened this issue Nov 22, 2023 · 0 comments · Fixed by #256
Assignees
@sleberknight
Labels
enhancement New feature or request
Milestone
2.1.0

Comments

@sleberknight
Copy link
Member

Blocked by kiwiproject/kiwi#1080 and release 3.2.0 of kiwi

Support providing a value for the boolean disableSniHostCheck property to support configuration via external config, system property, environment variable, etc.
@sleberknight sleberknight added enhancement New feature or request blocked Blocked by another issue, PR, etc. labels Nov 22, 2023
@sleberknight sleberknight added this to the 2.1.0 milestone Nov 22, 2023
@sleberknight sleberknight self-assigned this Nov 22, 2023
@sleberknight sleberknight removed the blocked Blocked by another issue, PR, etc. label Nov 25, 2023
sleberknight added a commit that referenced this issue Nov 25, 2023
@sleberknight
Support disableSniHostCheck in TlsConfigProvider
56008e5 
* Add the ability to configure disableSniHostCheck in TlsConfigProvider
* Fix the "see" reference in TlsConfigProvider javadocs
* Create TestHelpers utility class and extract common code into
  factory methods to create FieldResolverStrategy instances and
  a method to mock KiwiEnvironment to return a specified value

Closes #250
Closes #251
@sleberknight sleberknight mentioned this issue Nov 25, 2023
Merged
dsingley pushed a commit that referenced this issue Nov 26, 2023
@sleberknight
Support disableSniHostCheck in TlsConfigProvider (#256)
7b2fb63 
* Add the ability to configure disableSniHostCheck in TlsConfigProvider
* Fix the "see" reference in TlsConfigProvider javadocs
* Create TestHelpers utility class and extract common code into
  factory methods to create FieldResolverStrategy instances and
  a method to mock KiwiEnvironment to return a specified value

Closes #250
Closes #251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

Support disableSniHostCheck in TlsConfigProvider kiwiproject/dropwizard-config-providers
1 participant
@sleberknight