Sonar cleanup: Local variables should not shadow class fields (java:S…

…1117) (#175)
kiwiproject · Jun 3, 2024 · 1ccceb4 · 1ccceb4
1 parent 782adfe
commit 1ccceb4
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/src/test/java/org/kiwiproject/dropwizard/consul/core/ConsulAdvertiserTest.java b/src/test/java/org/kiwiproject/dropwizard/consul/core/ConsulAdvertiserTest.java
@@ -249,7 +249,7 @@ void testHostFromConfig() {
         factory.setServiceAddress("127.0.0.1");
 
         when(agent.isRegistered(anyString())).thenReturn(false);
-        var advertiser = new ConsulAdvertiser(environment, factory, consul, serviceId);
+        advertiser = new ConsulAdvertiser(environment, factory, consul, serviceId);
         registerAndEnsureRegistered(advertiser);
 
         var registration = ImmutableRegistration.builder()
@@ -275,7 +275,7 @@ void testTagsFromConfig() {
         factory.setTags(tags);
 
         when(agent.isRegistered(serviceId)).thenReturn(false);
-        var advertiser = new ConsulAdvertiser(environment, factory, consul, serviceId);
+        advertiser = new ConsulAdvertiser(environment, factory, consul, serviceId);
         registerAndEnsureRegistered(advertiser);
 
         var registration = ImmutableRegistration.builder()
@@ -301,7 +301,7 @@ void testAclTokenFromConfig() {
         factory.setAclToken(aclToken);
 
         when(agent.isRegistered(serviceId)).thenReturn(false);
-        var advertiser = new ConsulAdvertiser(environment, factory, consul, serviceId);
+        advertiser = new ConsulAdvertiser(environment, factory, consul, serviceId);
         registerAndEnsureRegistered(advertiser);
 
         var registration = ImmutableRegistration.builder()
@@ -327,7 +327,7 @@ void testServiceMetaFromConfig() {
         factory.setServiceMeta(serviceMeta);
 
         when(agent.isRegistered(serviceId)).thenReturn(false);
-        var advertiser = new ConsulAdvertiser(environment, factory, consul, serviceId);
+        advertiser = new ConsulAdvertiser(environment, factory, consul, serviceId);
         registerAndEnsureRegistered(advertiser);
 
         var registration = ImmutableRegistration.builder()
@@ -355,7 +355,7 @@ void testHealthCheckUrlFromConfig() {
         var configuredHealthCheckUrl = "http://127.0.0.1:8081/admin/ping";
 
         when(agent.isRegistered(anyString())).thenReturn(false);
-        var advertiser = new ConsulAdvertiser(environment, factory, consul, serviceId);
+        advertiser = new ConsulAdvertiser(environment, factory, consul, serviceId);
         registerAndEnsureRegistered(advertiser);
 
         var registration = ImmutableRegistration.builder()
@@ -386,15 +386,13 @@ private static boolean register(ConsulAdvertiser advertiser) {
 
     @Test
     void testDeregister() {
-        var serviceId = advertiser.getServiceId();
         when(agent.isRegistered(serviceId)).thenReturn(true);
         advertiser.deregister();
         verify(agent).deregister(serviceId);
     }
 
     @Test
     void testDeregisterNotRegistered() {
-        var serviceId = advertiser.getServiceId();
         when(agent.isRegistered(serviceId)).thenReturn(false);
         advertiser.deregister();
         verify(agent, never()).deregister(serviceId);