Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isDisabled to ConsulFactory #122

Closed
sleberknight opened this issue Aug 7, 2023 · 0 comments · Fixed by #123
Closed

Add isDisabled to ConsulFactory #122

sleberknight opened this issue Aug 7, 2023 · 0 comments · Fixed by #123
Assignees
@sleberknight
Labels
new feature A new feature such as a new class, method, package, group of classes, etc.
Milestone
1.1.0

Comments

@sleberknight
Copy link
Member

ConsulFactory has an isEnabled method. Sometimes client code wants to check if it is disabled instead of enabled. So, add an isDisabled method. Also, this should be ignored when serializing to JSON, since we don't need both enabled and a disabled properties in the JSON.
@sleberknight sleberknight added the new feature A new feature such as a new class, method, package, group of classes, etc. label Aug 7, 2023
@sleberknight sleberknight added this to the 1.0.1 milestone Aug 7, 2023
@sleberknight sleberknight self-assigned this Aug 7, 2023
sleberknight added a commit that referenced this issue Aug 8, 2023
@sleberknight
Add isDisabled to ConsulFactory
6ade436 
Closes #122
@sleberknight sleberknight mentioned this issue Aug 8, 2023
Merged
sleberknight added a commit that referenced this issue Aug 8, 2023
@sleberknight
Add isDisabled to ConsulFactory (#123)
43e7050 
Closes #122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
new feature A new feature such as a new class, method, package, group of classes, etc.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

Add isDisabled to ConsulFactory kiwiproject/dropwizard-consul
1 participant
@sleberknight