Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logback-classic dependency #132

Closed
sleberknight opened this issue Apr 18, 2022 · 0 comments · Fixed by #133
Closed

Remove logback-classic dependency #132

sleberknight opened this issue Apr 18, 2022 · 0 comments · Fixed by #133
Assignees
@sleberknight
Labels
API change Change to a public API dependencies Dependency updates
Milestone
2.0.0

Comments

@sleberknight
Copy link
Member

sleberknight commented Apr 18, 2022 •
edited
Loading

Remove the test-scoped logback-classic dependency from the parent POM, because whenever it revs, it causes dependency convergence conflicts when dependabot submits PRs. By moving it to the BOM, we control its version in one and only one place. In addition, previously it was always defined as test-scope, which might or might not be what a project inheriting from this parent wants. The downside is that it will now need to be defined in all our projects.

See /kiwiproject/kiwi-bom/issues/167
@sleberknight sleberknight added dependencies Dependency updates API change Change to a public API labels Apr 18, 2022
@sleberknight sleberknight added this to the 1.8.3 milestone Apr 18, 2022
sleberknight added a commit that referenced this issue Apr 18, 2022
@sleberknight
Remove slf4j-api and logback-classic dependencies
790a00b 
Closes #131
Closes #132
@sleberknight sleberknight mentioned this issue Apr 18, 2022
Merged
@sleberknight sleberknight added the in progress A task that is actively being worked on label Apr 18, 2022
chrisrohr pushed a commit that referenced this issue Apr 19, 2022
@sleberknight
Remove slf4j-api and logback-classic dependencies (#133)
576e3d6 
Closes #131
Closes #132
@sleberknight sleberknight removed the in progress A task that is actively being worked on label Apr 20, 2022
@sleberknight sleberknight self-assigned this Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
API change Change to a public API dependencies Dependency updates
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Remove slf4j-api and logback-classic dependencies kiwiproject/kiwi-parent
1 participant
@sleberknight