Enhancements to SSL/TLS configuration and context classes

[sleberknight]

This is a "brain dump" from some notes I wrote down in meatspace. It is not in any particular order, but wanted to get this in here before I lose that "yellow sticky" notepad.

SSLContextConfiguration

• Add trustStoreType, then fix converters to/from toSimpleSSLContextFactory, TlsContextConfiguration and TlsConfiguration
• toTlsContextConfiguration would need to change
• the overloaded method that accepts trustStoreType would (probably) not be needed anymore (deprecate it)
• The getTrustStoreType() method should be removed, since it explicitly returns keyStoreType (not a typo)

SecureEndpointsConfiguration

• Support key and trust store type
• Modify to SecureEndpointsConfiguration.Builder to allow setting the trustStoreType

SimpleSSLContextFactory

• Does not support key or trust store type
• It assumes JKS
• Add support for different key and trust store type
• Make JKS the default key and trust store type

TlsContextConfiguration

Does not support any of the following from Dropwizard's TlsConfiguration:

• certAlias
• keyStoreProvider
• provider
• supportedCiphers
• trustSelfSignedCertificates
• trustStoreProvider

We should also look to see if TlsConfiguration has added any additional properties that we might want to support.

Note that supportedCiphers is null by default in TlsConfiguration (just like supportedProtocols), so this is something we have to deal with and cannot change, even though I very much dislike having null collections.

SSLContextProtocol

Ensure that when we update to JDK 17 as a baseline, we provide all the accepted SSLContext algorithms listed in the Java Security Standard Algorithm Names (except SSL which our javadoc already says we exclude since it should not be used anymore). Note that I verifed that Java 18,19, and 20 have the same set of algorithms as 17, so we are safe through at least Java 20.

[sleberknight]

Created issues:

• Support trustStoreType in SSLContextConfiguration #936
• Support trustStoreType in SecureEndpointsConfiguration #937
• Support key and trust store type in SimpleSSLContextFactory #938
• Support trustStoreType in TlsContextConfiguration #939
• TlsContextConfiguration should support all properties in Dropwizard's TlsConfiguration #940

SSLContextProtocol already contains all the SSLContext algorithms through Java 20, I did not create a new issue.

This discussion is now effectively closed.