Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support trustStoreType in SSLContextConfiguration #936

Closed
sleberknight opened this issue Apr 14, 2023 · 0 comments · Fixed by #968
Closed

Support trustStoreType in SSLContextConfiguration #936

sleberknight opened this issue Apr 14, 2023 · 0 comments · Fixed by #968
Assignees
@sleberknight
Labels
enhancement A request for change or improvement to an existing feature
Milestone
2.6.0

Comments

@sleberknight
Copy link
Member

  • Add trustStoreType field and add setters to the builder
  • Fix the converter methods toSimpleSSLContextFactory and toTlsContextConfiguration to include trust store type
  • Deprecate the overloaded toTlsContextConfiguration method that accepts a trustStoreType argument; it is not needed anymore
  • Remove the explicit getTrustStoreType() method, since it explicitly returns keyStoreType (this is not a typo; SSLContextConfiguration originally did not support a separate trust store type, which is what we're fixing here)

This originated from discussion #935 (Enhancements to SSL/TLS configuration and context classes)
@sleberknight sleberknight added the enhancement A request for change or improvement to an existing feature label Apr 14, 2023
@sleberknight sleberknight mentioned this issue Apr 14, 2023
Closed
sleberknight added a commit that referenced this issue Apr 26, 2023
@sleberknight
Add support for trustStoreType in SSL/TLS classes
5db3444 
* Support trustStoreType in SSLContextConfiguration (#936)
* Support trustStoreType in SecureEndpointsConfiguration (#937)
* Support key and trust store type in SimpleSSLContextFactory (#938)
* Support trustStoreType in TlsContextConfiguration (#939)

Closes #936
Closes #937
Closes #938
Closes #939
@sleberknight sleberknight self-assigned this Apr 26, 2023
@sleberknight sleberknight added this to the 2.6.0 milestone Apr 26, 2023
@sleberknight sleberknight mentioned this issue Apr 26, 2023
Merged
sleberknight added a commit that referenced this issue Apr 26, 2023
@sleberknight
Add support for trustStoreType in SSL/TLS classes (#968)
ea339d7 
* Support trustStoreType in SSLContextConfiguration (#936)
* Support trustStoreType in SecureEndpointsConfiguration (#937)
* Support key and trust store type in SimpleSSLContextFactory (#938)
* Support trustStoreType in TlsContextConfiguration (#939)

Closes #936
Closes #937
Closes #938
Closes #939
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
enhancement A request for change or improvement to an existing feature
Projects
None yet
Milestone
2.6.0
Development

Successfully merging a pull request may close this issue.

Add support for trustStoreType in SSL/TLS classes kiwiproject/kiwi
1 participant
@sleberknight