Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problems found by IntelliJ inspections #1013

Closed
sleberknight opened this issue Aug 6, 2023 · 0 comments · Fixed by #1017
Closed

Fix problems found by IntelliJ inspections #1013

sleberknight opened this issue Aug 6, 2023 · 0 comments · Fixed by #1017
Assignees
@sleberknight
Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools
Milestone
3.0.0

Comments

@sleberknight
Copy link
Member

Once #1011 is complete, re-run IntellJ code inspections, and fix relevant issues. I already ran IntelliJ's inspections and it found a decent number of relevant issues, e.g. Java migration issues, some of which overlap with Sonar.
@sleberknight sleberknight added the code cleanup Fix issues reported by Sonar or any other code analysis tools label Aug 6, 2023
@sleberknight sleberknight added this to the 3.0.0 milestone Aug 6, 2023
@sleberknight sleberknight self-assigned this Aug 6, 2023
sleberknight added a commit that referenced this issue Aug 7, 2023
@sleberknight
Code cleanup (IntelliJ inspections)
c087125 
Various code cleanup from IntelliJ inspections.

Closes #1013
@sleberknight sleberknight mentioned this issue Aug 7, 2023
Merged
sleberknight added a commit that referenced this issue Aug 7, 2023
@sleberknight
Code cleanup (IntelliJ inspections) (#1017)
a28b2cf 
Various code cleanup from IntelliJ inspections.

Closes #1013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Code cleanup (IntelliJ inspections) kiwiproject/kiwi
1 participant
@sleberknight