Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regex problem in KiwiJars#getPathComponents #1201

Closed
sleberknight opened this issue Sep 19, 2024 · 0 comments · Fixed by #1202
Closed

Fix regex problem in KiwiJars#getPathComponents #1201

sleberknight opened this issue Sep 19, 2024 · 0 comments · Fixed by #1202
Assignees
@sleberknight
Labels
bug Something isn't working
Milestone
4.5.0

Comments

@sleberknight
Copy link
Member

IntelliJ flags this LOC:

return newArrayList(decodedJarPath.trim().split(File.separator));

with this warning:

File. separator is used as a regex; will not work on Windows

This can be fixed by quoting it using Pattern.quote.
@sleberknight sleberknight added the bug Something isn't working label Sep 19, 2024
@sleberknight sleberknight added this to the 4.5.0 milestone Sep 19, 2024
@sleberknight sleberknight self-assigned this Sep 19, 2024
sleberknight added a commit that referenced this issue Sep 19, 2024
@sleberknight
Quote "File.separator" when calling split in KiwiJars#getPathComponents
e314e2b 
This will make it work on Windows.

Fixes #1201
@sleberknight sleberknight mentioned this issue Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
bug Something isn't working
Projects
None yet
Milestone
4.5.0
Development

Successfully merging a pull request may close this issue.

Quote "File.separator" when calling split in KiwiJars#getPathComponents kiwiproject/kiwi
1 participant
@sleberknight