Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BeanConverter#convert should use Map keys as the property names #403

Closed
sleberknight opened this issue Nov 4, 2020 · 0 comments · Fixed by #404
Closed

BeanConverter#convert should use Map keys as the property names #403

sleberknight opened this issue Nov 4, 2020 · 0 comments · Fixed by #404
Assignees
@sleberknight
Labels
enhancement A request for change or improvement to an existing feature refactoring Code refactoring
Milestone
0.14.0

Comments

@sleberknight
Copy link
Member

sleberknight commented Nov 4, 2020 •
edited
Loading

When the input to BeanConverter#getPropertyList is a Map, it should use only the map's keys as the names of the properties for the target object. Exclusions should still apply, however.
@sleberknight sleberknight added enhancement A request for change or improvement to an existing feature refactoring Code refactoring labels Nov 4, 2020
@sleberknight sleberknight added this to the 0.14.0 milestone Nov 4, 2020
@sleberknight sleberknight self-assigned this Nov 4, 2020
sleberknight added a commit that referenced this issue Nov 4, 2020
@sleberknight
Better Map input handling in BeanConverter#convert
8bfc58e 
* Rename protected getPropertyList to getPropertySet (since it returns
  a Set<String> and saying we return a List is just a bit confusing...)
* Change BeanConverter#getPropertySet so that, when the input is a
  Map, we assume the properties are simply the keys in the Map

Fixes #403
@sleberknight sleberknight changed the title BeanConverter should take Map properties as the property list BeanConverter#convert should use Map keys as the property names Nov 4, 2020
@sleberknight sleberknight mentioned this issue Nov 4, 2020
Merged
chrisrohr pushed a commit that referenced this issue Nov 4, 2020
@sleberknight
Better Map input handling in BeanConverter#convert (#404)
ddee97e 
* Better Map input handling in BeanConverter#convert

* Rename protected getPropertyList to getPropertySet (since it returns
  a Set<String> and saying we return a List is just a bit confusing...)
* Change BeanConverter#getPropertySet so that, when the input is a
  Map, we assume the properties are simply the keys in the Map

Fixes #403

* * Rename exclusionList property (which is a Set) to just exclusions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
enhancement A request for change or improvement to an existing feature refactoring Code refactoring
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

Better Map input handling in BeanConverter#convert kiwiproject/kiwi
1 participant
@sleberknight