Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PagingParams interface #412

Closed
sleberknight opened this issue Nov 6, 2020 · 0 comments · Fixed by #441
Closed

Add PagingParams interface #412

sleberknight opened this issue Nov 6, 2020 · 0 comments · Fixed by #441
Assignees
@sleberknight
Labels
new feature A new feature such as a new class, method, package, group of classes, etc.
Milestone
0.15.0

Comments

@sleberknight
Copy link
Member

sleberknight commented Nov 6, 2020 •
edited
Loading

Simple interface defining paging parameters, e.g. that might be submitted via an HTTP request.

The params are specific to some of our service requirements:

  • page: Integer
  • limit: Integer
  • primarySort: String
  • primaryDirection: Sort.Direction
  • secondarySort: String
  • secondaryDirection: Sort.Direction

Notes:

  • Our requirements dictated ability to have a primary and a secondary sort field and direction, which is the reason for the primary and secondary sort parameters.
  • The Sort.Direction is a Spring Data class/enum, which is why this is in the org.kiwiproject.spring.data package
@sleberknight sleberknight added the new feature A new feature such as a new class, method, package, group of classes, etc. label Nov 6, 2020
@sleberknight sleberknight added this to the 0.15.0 milestone Nov 6, 2020
@sleberknight sleberknight changed the title Add Add PagingParams interface Nov 6, 2020
@sleberknight sleberknight self-assigned this Nov 13, 2020
@sleberknight sleberknight mentioned this issue Nov 13, 2020
Closed
sleberknight added a commit that referenced this issue Nov 13, 2020
@sleberknight
Add PagingParams interface and PagingRequest implementation
6e553bd 
Fixes #412
Fixes #413
@sleberknight sleberknight mentioned this issue Nov 13, 2020
Merged
chrisrohr added a commit that referenced this issue Nov 13, 2020
@sleberknight @chrisrohr
Add PagingParams interface and PagingRequest implementation (#441)
aab7267 
* Add PagingParams interface and PagingRequest implementation

Fixes #412
Fixes #413

* Update PagingRequestTest.java

Co-authored-by: Chris Rohr <51920+chrisrohr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
new feature A new feature such as a new class, method, package, group of classes, etc.
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

Add PagingParams interface and PagingRequest implementation kiwiproject/kiwi
1 participant
@sleberknight