Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KiwiSpringMongoQueries #415

Closed
sleberknight opened this issue Nov 6, 2020 · 1 comment · Fixed by #454
Closed

Add KiwiSpringMongoQueries #415

sleberknight opened this issue Nov 6, 2020 · 1 comment · Fixed by #454
Assignees
@sleberknight
Labels
new feature A new feature such as a new class, method, package, group of classes, etc.
Milestone
0.16.0

Comments

@sleberknight
Copy link
Member

sleberknight commented Nov 6, 2020 •
edited
Loading

Contains static utilities for adding criteria to Spring Data MongoDB queries.

Formerly named MongoQuery. Rename to KiwiSpringMongoQueries.
@sleberknight sleberknight added the new feature A new feature such as a new class, method, package, group of classes, etc. label Nov 6, 2020
@sleberknight sleberknight added this to the 0.15.0 milestone Nov 6, 2020
@sleberknight
Copy link
Member Author

Note this depends on #416

@sleberknight sleberknight self-assigned this Nov 14, 2020
@sleberknight sleberknight changed the title Add MongoQuery Add KiwiSpringMongoQueries Nov 14, 2020
@sleberknight sleberknight modified the milestones: 0.15.0, 0.16.0 Nov 15, 2020
@sleberknight sleberknight mentioned this issue Nov 23, 2020
Closed
sleberknight added a commit that referenced this issue Nov 24, 2020
@sleberknight
Add Spring Data MongoDB querying utilities
67f1e3e 
* Add KiwiSpringMongoQueries which contains static utilities
* Add PagingQuery and companion class AggregateResult
* Marked PagingQuery#aggregatePage and AggregateResult with the @beta
  annotation and put all kinds of caveats and potential issues in the
  docs.
* Note that the KiwiSpringMongoQueriesTest uses the in-memory
  de.bwaldvogel.mongo.MongoServer while PagingQueryAggregatePageTest
  requires a "real" MongoDB instance to run. For whatever reason the
  in-memory MongoServer blows up with an NPE during the aggregation
  and I don't know if the fault is with it or with our code. So, for
  now the test only runs if several system properties are set that
  tell it to use a "real" MongoDB and where that server is running.

Fixes #415
Fixes #416
@sleberknight sleberknight mentioned this issue Nov 24, 2020
Merged
chrisrohr added a commit that referenced this issue Nov 24, 2020
@sleberknight @chrisrohr
Add Spring Data MongoDB querying utilities (#454)
3a49369 
* Add Spring Data MongoDB querying utilities

* Add KiwiSpringMongoQueries which contains static utilities
* Add PagingQuery and companion class AggregateResult
* Marked PagingQuery#aggregatePage and AggregateResult with the @beta
  annotation and put all kinds of caveats and potential issues in the
  docs.
* Note that the KiwiSpringMongoQueriesTest uses the in-memory
  de.bwaldvogel.mongo.MongoServer while PagingQueryAggregatePageTest
  requires a "real" MongoDB instance to run. For whatever reason the
  in-memory MongoServer blows up with an NPE during the aggregation
  and I don't know if the fault is with it or with our code. So, for
  now the test only runs if several system properties are set that
  tell it to use a "real" MongoDB and where that server is running.

Fixes #415
Fixes #416

* Exclude PagingQuery from Sonar code coverage

* Exclude PagingQuery from Sonar code coverage, second try

* Update AggregateResultTest.java

Co-authored-by: Chris Rohr <51920+chrisrohr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
new feature A new feature such as a new class, method, package, group of classes, etc.
Projects
None yet
Milestone
0.16.0
Development

Successfully merging a pull request may close this issue.

Add Spring Data MongoDB querying utilities kiwiproject/kiwi
1 participant
@sleberknight