Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow retrieving binary content in SftpTransfers #431

Closed
sleberknight opened this issue Nov 11, 2020 · 0 comments · Fixed by #534
Closed

Allow retrieving binary content in SftpTransfers #431

sleberknight opened this issue Nov 11, 2020 · 0 comments · Fixed by #534
Assignees
@chrisrohr
Labels
enhancement A request for change or improvement to an existing feature
Milestone
0.22.0

Comments

@sleberknight
Copy link
Member

Creating this issue from a TODO in SftpTransfers, on the getFileContent method.

Should we provide the ability to retrieve the content of a remote binary file? What would the return type be, etc.?
@sleberknight sleberknight added the enhancement A request for change or improvement to an existing feature label Nov 11, 2020
chrisrohr added a commit that referenced this issue Apr 3, 2021
@chrisrohr
Add getFileContentsAsInputStream to allow for SftpTransfers to pull b…
069468c 
…inary content

Closes #431
@chrisrohr chrisrohr added this to the 0.22.0 milestone Apr 3, 2021
@chrisrohr chrisrohr self-assigned this Apr 3, 2021
@chrisrohr chrisrohr mentioned this issue Apr 3, 2021
Merged
sleberknight added a commit that referenced this issue Apr 6, 2021
@chrisrohr @sleberknight
Add getFileContentsAsInputStream to allow for SftpTransfers to pull b…
3c0d35d 
…inary content (#534)

* Add getFileContentsAsInputStream to allow for SftpTransfers to pull binary content

Closes #431

* Use KiwiIO.readInputStreamAsString instead of IOUtils.toString

This also has the added benefit of not needing to throw IOException
since KiwiIO methods throw UncheckedIOException.

Co-authored-by: Scott Leberknight <174812+sleberknight@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisrohr chrisrohr

Labels
enhancement A request for change or improvement to an existing feature
Projects
None yet
Milestone
0.22.0
Development

Successfully merging a pull request may close this issue.

Add getFileContentsAsInputStream to allow for SftpTransfers to pull binary content kiwiproject/kiwi
2 participants
@chrisrohr @sleberknight