Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add port to exception message thrown by LocalPortChecker#findFirstOpenPortAbove #477

Closed
sleberknight opened this issue Dec 8, 2020 · 0 comments · Fixed by #476
Closed

Add port to exception message thrown by LocalPortChecker#findFirstOpenPortAbove #477

sleberknight opened this issue Dec 8, 2020 · 0 comments · Fixed by #476
Assignees
@sleberknight
Labels
enhancement A request for change or improvement to an existing feature
Milestone
0.18.0

Comments

@sleberknight
Copy link
Member

The current message is just "Invalid start port"

A better message should include the port number that was invalid, e.g. "Invalid start port: -1"
@sleberknight sleberknight added the enhancement A request for change or improvement to an existing feature label Dec 8, 2020
@sleberknight sleberknight added this to the 0.18.0 milestone Dec 8, 2020
@sleberknight sleberknight self-assigned this Dec 8, 2020
@sleberknight sleberknight mentioned this issue Dec 8, 2020
Merged
chrisrohr pushed a commit that referenced this issue Dec 8, 2020
@sleberknight
Don't assume port 22 is always in use in LocalPortCheckerTest (#476)
1819975 
* Instead, just open a ServerSocket on a random port and use its
  port as the "in use" port. Simple and no assumptions.
* Minor update to the failure description in another test to make it
  more clear that we are intentionally halting a test
* Change several tests to use JUnit Jupiter @ParameterizedTest and
  added/updated failure description messages

LocalPortChecker:
* Add port to exception message thrown by findFirstOpenPortAbove method

Fixes #475
Closes #477
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
enhancement A request for change or improvement to an existing feature
Projects
None yet
Milestone
0.18.0
Development

Successfully merging a pull request may close this issue.

Don't assume port 22 is always in use in LocalPortCheckerTest kiwiproject/kiwi
1 participant
@sleberknight