Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KiwiMaps.newConcurrentHashMap should return a ConcurrentMap #486

Closed
sleberknight opened this issue Dec 18, 2020 · 1 comment · Fixed by #487
Closed

KiwiMaps.newConcurrentHashMap should return a ConcurrentMap #486

sleberknight opened this issue Dec 18, 2020 · 1 comment · Fixed by #487
Assignees
@sleberknight
Labels
enhancement A request for change or improvement to an existing feature
Milestone
0.18.0

Comments

@sleberknight
Copy link
Member

For same reasons in #484 the KiwiMaps.newConcurrentMap method should return a ConcurrentMap.

Verified that the original code does return ConcurrentMap
@sleberknight sleberknight added the enhancement A request for change or improvement to an existing feature label Dec 18, 2020
@sleberknight sleberknight added this to the 0.18.0 milestone Dec 18, 2020
@sleberknight sleberknight self-assigned this Dec 18, 2020
@sleberknight sleberknight changed the title KiwiMaps.newConcurrentMap should return a ConcurrentMap KiwiMaps.newConcurrentHashMap should return a ConcurrentMap Dec 18, 2020
@sleberknight
Copy link
Member Author

Signature should be:

public static <K, V> ConcurrentMap<K, V> newConcurrentHashMap(Object... items)

sleberknight added a commit that referenced this issue Dec 18, 2020
@sleberknight
Change to more appropriate return types in KiwiMaps
1b5848c 
* Change newTreeMap to return SortedMap
* Change newConcurrentHashMap to return ConcurrentMap

Closes #484
Closes #486
@sleberknight sleberknight mentioned this issue Dec 18, 2020
Merged
chrisrohr pushed a commit that referenced this issue Dec 21, 2020
@sleberknight
Change to more appropriate return types in KiwiMaps (#487)
f99152d 
* Change newTreeMap to return SortedMap
* Change newConcurrentHashMap to return ConcurrentMap
* Use Comparable<? super K> instead of raw Comparable type
* Add a few sanity checking tests

Closes #484
Closes #486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
enhancement A request for change or improvement to an existing feature
Projects
None yet
Milestone
0.18.0
Development

Successfully merging a pull request may close this issue.

Change to more appropriate return types in KiwiMaps kiwiproject/kiwi
1 participant
@sleberknight