Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change guava-retrying dependency to (forked) re-retrying 3.0.0 #488

Closed
sleberknight opened this issue Dec 21, 2020 · 0 comments · Fixed by #489
Closed

Change guava-retrying dependency to (forked) re-retrying 3.0.0 #488

sleberknight opened this issue Dec 21, 2020 · 0 comments · Fixed by #489
Assignees
Labels
dependencies Dependency updates
Milestone

Comments

@sleberknight
Copy link
Member

sleberknight commented Dec 21, 2020

Summary

This task is to change kiwi to use the re-retrying library version 3.0.0, which is a fork of the original (and dead) guava-retrying library. The Maven coordinates are:

<!-- https://mvnrepository.com/artifact/tech.huffman.re-retrying/re-retrying -->
<dependency>
    <groupId>tech.huffman.re-retrying</groupId>
    <artifactId>re-retrying</artifactId>
    <version>3.0.0</version>
</dependency>

Alas, re-retrying is also now dead, which we will still need to deal with.

Background

This issue comes from investigation task #481 :

Note that I think it is worth it to start with immediately changing to the 3.0.0 version of the forked re-retrying library since it actually resolves some compile errors that occur in guava-retrying after Guava 22. It also made the JSR 302 dependency as compileOnly in the build (which I assume is the Gradle equivalent of Maven's provided scope) -- see https://blog.gradle.org/introducing-compile-only-dependencies for description of Gradle compileOnly

See https://github.com/rhuffman/re-retrying/releases/tag/v3.0.0

Originally posted by @sleberknight in #481 (comment)


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependency updates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant