Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overloaded verifyExistence methods to KiwiResources that accept varags #663

Closed
sleberknight opened this issue Jan 27, 2022 · 2 comments · Fixed by #664
Closed

Add overloaded verifyExistence methods to KiwiResources that accept varags #663

sleberknight opened this issue Jan 27, 2022 · 2 comments · Fixed by #664
Assignees
@sleberknight
Labels
new feature A new feature such as a new class, method, package, group of classes, etc.
Milestone
1.3.0

Comments

@sleberknight
Copy link
Member

We have:

public static <T> void verifyExistence(T resourceEntity, String notFoundMessage)

// and 

public static <T> T verifyExistence(Optional<T> resourceEntity, String notFoundMessage)

We should add overloads to allow parameterized messages:

public static <T> void verifyExistence(T resourceEntity, String notFoundMessageTemplate, Object... args)

// and 

public static <T> T verifyExistence(Optional<T> resourceEntity, String notFoundMessage, Object... args)
@sleberknight sleberknight added the new feature A new feature such as a new class, method, package, group of classes, etc. label Jan 27, 2022
@sleberknight sleberknight self-assigned this Jan 28, 2022
@sleberknight sleberknight added this to the 1.2.2 milestone Jan 28, 2022
@sleberknight sleberknight added the in progress A task that is actively being worked on label Jan 28, 2022
@sleberknight
Copy link
Member Author

@chrisrohr Since this is a new feature to the API, it should be a minor release bump, and thus the milestone should be changed to 1.3.0 right?

@chrisrohr
Copy link
Contributor

chrisrohr commented Jan 28, 2022 via email

sleberknight added a commit that referenced this issue Jan 28, 2022
@sleberknight
Add verifyExistence methods that accept varargs in KiwiResources
3cf1cf6 
* Add verifyExistence methods in KiwiResources that accept a message
  template and a variable number of arguments; they use the
  KiwiStrings#format method to perform the argument substitution
* Fix typo in javadoc of JaxrsNotFoundException#buildMessage

Closes #663
@sleberknight sleberknight mentioned this issue Jan 28, 2022
Merged
chrisrohr pushed a commit that referenced this issue Jan 28, 2022
@sleberknight
Add verifyExistence methods that accept varargs in KiwiResources (#664)
9b47279 
* Add verifyExistence methods in KiwiResources that accept a message
  template and a variable number of arguments; they use the
  KiwiStrings#format method to perform the argument substitution
* Fix typo in javadoc of JaxrsNotFoundException#buildMessage

Closes #663
@sleberknight sleberknight removed the in progress A task that is actively being worked on label Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
new feature A new feature such as a new class, method, package, group of classes, etc.
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Add verifyExistence methods that accept varargs in KiwiResources kiwiproject/kiwi
2 participants
@chrisrohr @sleberknight