Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kiwi validators should not require use of EL (expression language) #721

Closed
sleberknight opened this issue May 22, 2022 · 0 comments · Fixed by #723
Closed

Kiwi validators should not require use of EL (expression language) #721

sleberknight opened this issue May 22, 2022 · 0 comments · Fixed by #723
Assignees
@sleberknight
Labels
refactoring Code refactoring
Milestone
2.1.0

Comments

@sleberknight
Copy link
Member

sleberknight commented May 22, 2022 •
edited
Loading

Change any kiwi custom validators that currently use EL so they do not require its use. This is due to a change in Hibernate Validator 6.2.x in which the expression language is disabled by default for custom validators. Refer to #690 for a more thorough discussion. By removing the requirement for using EL in our validators, we can safely upgrade to Hibernate Validator 6.2.x.
@sleberknight sleberknight added the refactoring Code refactoring label May 22, 2022
@sleberknight sleberknight added this to the 2.1.0 milestone May 22, 2022
@sleberknight sleberknight self-assigned this May 22, 2022
sleberknight added a commit that referenced this issue May 22, 2022
@sleberknight
Remove use of expression language in validators
f72eb54 
Remove use of EL in Range and FieldRangeValidator by splitting each
message template into separate templates, one that uses the min/max
annotation value and one that uses the minLabel/maxLabel annotation
value. This makes the validator implementation a little more
complicated, by requiring them to determine which template to use.
This is done once in the initialize method.

See #690 for details on Hibernate Validator disabling EL by default
in version 6.2.x and higher.

Closes #721
@sleberknight sleberknight mentioned this issue May 22, 2022
Merged
chrisrohr pushed a commit that referenced this issue May 31, 2022
@sleberknight
Remove use of expression language in validators (#723)
8fd21ca 
Remove use of EL in Range and FieldRangeValidator by splitting each
message template into separate templates, one that uses the min/max
annotation value and one that uses the minLabel/maxLabel annotation
value. This makes the validator implementation a little more
complicated, by requiring them to determine which template to use.
This is done once in the initialize method.

See #690 for details on Hibernate Validator disabling EL by default
in version 6.2.x and higher.

Closes #721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
refactoring Code refactoring
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

Remove use of expression language in validators kiwiproject/kiwi
1 participant
@sleberknight