Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SimpleRetryerConfig #803

Closed
sleberknight opened this issue Nov 11, 2022 · 0 comments · Fixed by #805
Closed

Add SimpleRetryerConfig #803

sleberknight opened this issue Nov 11, 2022 · 0 comments · Fixed by #805
Assignees
@sleberknight
Labels
new feature A new feature such as a new class, method, package, group of classes, etc.
Milestone
2.4.0

Comments

@sleberknight
Copy link
Member

Add a SimpleRetryerConfig class that can be used to configure a SimpleRetryer, e.g. from an external YAML configuration file in a (Dropwizard) service.

Once in place, we can add a factory method to make it easy to create a new SimpleRetryer instance from a configuration object, e.g.

var retryerConfig = configuration.getRetryerConfig();
var retryer = SimpleRetryer.from(retryerConfig);
@sleberknight sleberknight added the new feature A new feature such as a new class, method, package, group of classes, etc. label Nov 11, 2022
@sleberknight sleberknight added this to the 2.4.0 milestone Nov 11, 2022
@sleberknight sleberknight self-assigned this Nov 11, 2022
This was referenced Nov 11, 2022
Closed
Merged
chrisrohr pushed a commit that referenced this issue Nov 14, 2022
@sleberknight
Add SimpleRetryerConfig (#805)
7456915 
* Add SimpleRetryerConfig class and tests
* Note that I used JUnit Jupiter's assertAll instead of AssertJ SoftAssertions
   because they are much faster; SoftAssertions takes a second or two to
   initialize for some reason.

Closes #803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
new feature A new feature such as a new class, method, package, group of classes, etc.
Projects
None yet
Milestone
2.4.0
Development

Successfully merging a pull request may close this issue.

Add SimpleRetryerConfig kiwiproject/kiwi
1 participant
@sleberknight