Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "alias" methods to compute zero-based offset for one and zero-based pagination #830

Closed
sleberknight opened this issue Dec 28, 2022 · 0 comments · Fixed by #831
Closed

Add "alias" methods to compute zero-based offset for one and zero-based pagination #830

sleberknight opened this issue Dec 28, 2022 · 0 comments · Fixed by #831
Assignees
@sleberknight
Labels
new feature A new feature such as a new class, method, package, group of classes, etc.
Milestone
2.5.0

Comments

@sleberknight
Copy link
Member

Add two new "alias" methods to KiwiSearching for ease of use and better API "ergonomics":

  • zeroBasedOffsetForOneBasedPaging(int pageNumber, int pageSize) - this is an alias of the original zeroBasedOffset(int pageNumber, int pageSize)
  • zeroBasedOffsetForZeroBasedPaging(int pageNumber, int pageSize) - this is a shorter way than calling the zeroBasedOffset overload that accepts a PageNumberingScheme

I'm adding this only because I was working in a service recently that was using zero-based paging, and I had to call zeroBasedOffset(pageNumber, PageNumberingScheme.ZERO_BASED, pageSize) in various places. This was annoying, so why not just add shorthand methods with names that are clear?
@sleberknight sleberknight added the new feature A new feature such as a new class, method, package, group of classes, etc. label Dec 28, 2022
@sleberknight sleberknight added this to the 2.5.0 milestone Dec 28, 2022
@sleberknight sleberknight self-assigned this Dec 28, 2022
@sleberknight sleberknight linked a pull request Dec 29, 2022 that will close this issue
Add "alias" methods to compute zero-based offsets to KiwiSearching #831
Merged
@sleberknight sleberknight mentioned this issue Dec 29, 2022
Merged
sleberknight added a commit that referenced this issue Dec 29, 2022
@sleberknight
Add "alias" methods to compute zero-based offsets to KiwiSearching (#831
5b0eb96 
)

Closes #830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
new feature A new feature such as a new class, method, package, group of classes, etc.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

Add "alias" methods to compute zero-based offsets to KiwiSearching kiwiproject/kiwi
1 participant
@sleberknight