Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PageNumberingScheme.minimumPageNumber public #832

Closed
sleberknight opened this issue Dec 29, 2022 · 0 comments · Fixed by #833
Closed

Make PageNumberingScheme.minimumPageNumber public #832

sleberknight opened this issue Dec 29, 2022 · 0 comments · Fixed by #833
Assignees
@sleberknight
Labels
enhancement A request for change or improvement to an existing feature
Milestone
2.5.0

Comments

@sleberknight
Copy link
Member

sleberknight commented Dec 29, 2022 •
edited
Loading

Make the minimumPageNumber field in the KiwiSearching.PageNumberingScheme enum public, and also provide a "traditional" getter.

This is needed by #829 in order to determine what the minimum page number is.
@sleberknight sleberknight added the enhancement A request for change or improvement to an existing feature label Dec 29, 2022
@sleberknight sleberknight added this to the 2.5.0 milestone Dec 29, 2022
@sleberknight sleberknight self-assigned this Dec 29, 2022
sleberknight added a commit that referenced this issue Dec 29, 2022
@sleberknight
Make minimumPageNumber public in PageNumberingScheme enum
99791e1 
By making this public, other classes can perform calculations while
taking this value into account. Otherwise, they would need to hard
code a zero or a one, as I found while implementing another issue.

Closes #832
@sleberknight sleberknight mentioned this issue Dec 29, 2022
Merged
sleberknight added a commit that referenced this issue Dec 29, 2022
@sleberknight
Make minimumPageNumber public in PageNumberingScheme enum (#833)
cd9eb2b 
By making this public, other classes can perform calculations while
taking this value into account. Otherwise, they would need to hard
code a zero or a one, as I found while implementing another issue.

Closes #832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
enhancement A request for change or improvement to an existing feature
Projects
None yet
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

Make minimumPageNumber public in PageNumberingScheme enum kiwiproject/kiwi
1 participant
@sleberknight