Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KiwiReflection#newInstanceExactParamTypes should permit null arguments #856

Closed
sleberknight opened this issue Jan 27, 2023 · 0 comments · Fixed by #857
Closed

KiwiReflection#newInstanceExactParamTypes should permit null arguments #856

sleberknight opened this issue Jan 27, 2023 · 0 comments · Fixed by #857
Assignees
Labels
enhancement A request for change or improvement to an existing feature
Milestone

Comments

@sleberknight
Copy link
Member

KiwiReflection#newInstanceExactParamTypes uses List.of to wrap the varargs into a List, but this will throw a NPE if any argument is null:

return newInstance(type, parameterTypes, List.of(arguments));

In this method, null arguments are OK, because we have the exact parameter types and therefore do not need to infer the types, as we do in newInstanceInferringParamTypes.

So, the List creation needs to permit null values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A request for change or improvement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant