Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code scanning alert - Dereferenced variable may be null #861

Closed
1 task
sleberknight opened this issue Jan 30, 2023 · 0 comments · Fixed by #895
Closed
1 task

Fix code scanning alert - Dereferenced variable may be null #861

sleberknight opened this issue Jan 30, 2023 · 0 comments · Fixed by #895
Assignees
@sleberknight
Labels
bug Something isn't working
Milestone
2.5.0

Comments

@sleberknight
Copy link
Member

Tracking issue for:

In addition, the logic needs to be re-thought for the three arguments, and the Javadoc also needs to be corrected since it mentions "both" arguments (again, there are three).
@sleberknight sleberknight added the bug Something isn't working label Jan 30, 2023
@sleberknight sleberknight added this to the 2.5.0 milestone Jan 31, 2023
sleberknight added a commit that referenced this issue Jan 31, 2023
@sleberknight
CodeQL: Fix "Dereferenced variable may be null " in KiwiSecurity
95a63a6 
* Change getKeyStore methods so that they return an empty Optional if
  either path or password is null.
* Update Javadocs to match new implementation and explain the intent
  of these methods is to load an existing key store, not create a new one.
* Fix several tests that were asserting that the returned Optional was not
  null instead of it containing a value.

Fixes #861
@sleberknight sleberknight mentioned this issue Jan 31, 2023
Merged
sleberknight added a commit that referenced this issue Jan 31, 2023
@sleberknight
CodeQL: Fix "Dereferenced variable may be null " in KiwiSecurity (#895)
2e70007 
* Change getKeyStore methods so that they return an empty Optional if
  either path or password is null.
* Update Javadocs to match new implementation and explain the intent
  of these methods is to load an existing key store, not create a new one.
* Fix several tests that were asserting that the returned Optional was not
  null instead of it containing a value.

Fixes #861
sleberknight added a commit that referenced this issue Jan 31, 2023
@sleberknight
CodeQL: Fix "Dereferenced variable may be null " in KiwiSecurity (#895)
33115bb 
* Change getKeyStore methods so that they return an empty Optional if
  either path or password is null.
* Update Javadocs to match new implementation and explain the intent
  of these methods is to load an existing key store, not create a new one.
* Fix several tests that were asserting that the returned Optional was not
  null instead of it containing a value.

Fixes #861
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
bug Something isn't working
Projects
None yet
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

CodeQL: Fix "Dereferenced variable may be null " in KiwiSecurity kiwiproject/kiwi
1 participant
@sleberknight