Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code scanning alert - Log Injection #883

Closed
1 task
sleberknight opened this issue Jan 30, 2023 · 0 comments · Fixed by #898
Closed
1 task

Fix code scanning alert - Log Injection #883

sleberknight opened this issue Jan 30, 2023 · 0 comments · Fixed by #898
Assignees
@sleberknight
Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools
Milestone
2.5.0

Comments

@sleberknight
Copy link
Member

Tracking issue for:
@sleberknight sleberknight added the code cleanup Fix issues reported by Sonar or any other code analysis tools label Jan 30, 2023
sleberknight added a commit that referenced this issue Jan 31, 2023
@sleberknight
CodeQL: Fix "Log Injection" in path validators
f183a73 
Fix log injection in FilePathValidator and DirectoryPathValidator
by removing the path from the log message. I can't find something
to easily (and with 100% certainty) sanitize the path from all possible
badness, so just removing it entirely.

Add message about the Nul character in FilePathValidator just like the
DirectortPathValidator has. Extracted Nul character check to
package-private method in InternalKiwiValidators.

Fixes #880
Fixes #883
@sleberknight sleberknight added this to the 2.5.0 milestone Jan 31, 2023
@sleberknight sleberknight self-assigned this Jan 31, 2023
@sleberknight sleberknight mentioned this issue Jan 31, 2023
Merged
sleberknight added a commit that referenced this issue Jan 31, 2023
@sleberknight
CodeQL: Fix "Log Injection" in path validators (#898)
ea2c15d 
Fix log injection in FilePathValidator and DirectoryPathValidator
by removing the path from the log message. I can't find something
to easily (and with 100% certainty) sanitize the path from all possible
badness, so just removing it entirely.

Add message about the Nul character in FilePathValidator just like the
DirectortPathValidator has. Extracted Nul character check to
package-private method in InternalKiwiValidators.

Fixes #880
Fixes #883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools
Projects
None yet
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

CodeQL: Fix "Log Injection" in path validators kiwiproject/kiwi
1 participant
@sleberknight