Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate KiwiDropwizardDurations#fromDropwizardDuration #921

Closed
sleberknight opened this issue Mar 24, 2023 · 0 comments · Fixed by #922
Closed

Deprecate KiwiDropwizardDurations#fromDropwizardDuration #921

sleberknight opened this issue Mar 24, 2023 · 0 comments · Fixed by #922
Assignees
@sleberknight
Labels
deprecation Deprecates an existing feature
Milestone
2.6.0

Comments

@sleberknight
Copy link
Member

Since Dropwizard's Duration class now has the toJavaDuration method (which I know about because I contributed it to Dropwizard 😉), we can deprecate KiwiDropwizardDurations#fromDropwizardDuration.

So, instead of:

var javaDuration = KiwiDropwizardDurations.fromDropwizardDuration(dwDuration);

you can now just do the more pleasant:

var javaDuration = dwDuration.toJavaDuration();

For now, we will just deprecate it but not for removal. Maybe we can decide to remove it at some point, but at present it isn't hurting anything.
@sleberknight sleberknight added the deprecation Deprecates an existing feature label Mar 24, 2023
@sleberknight sleberknight added this to the 2.6.0 milestone Mar 24, 2023
@sleberknight sleberknight self-assigned this Mar 24, 2023
sleberknight added a commit that referenced this issue Mar 24, 2023
@sleberknight
Deprecate KiwiDropwizardDurations#fromDropwizardDuration
334cb06 
* Deprecate fromDropwizardDuration; add various deprecation annotations
* Add missing javadoc

Closes #921
@sleberknight sleberknight mentioned this issue Mar 24, 2023
Merged
sleberknight added a commit that referenced this issue Mar 24, 2023
@sleberknight
Deprecate KiwiDropwizardDurations#fromDropwizardDuration (#922)
a0bc9e8 
* Deprecate fromDropwizardDuration; add various deprecation annotations
* Add missing javadoc

Closes #921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
deprecation Deprecates an existing feature
Projects
None yet
Milestone
2.6.0
Development

Successfully merging a pull request may close this issue.

Deprecate KiwiDropwizardDurations#fromDropwizardDuration kiwiproject/kiwi
1 participant
@sleberknight