Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document limitations on known host formats in KiwiJSchHelpers #932

Closed
sleberknight opened this issue Apr 10, 2023 · 0 comments · Fixed by #958
Closed

Document limitations on known host formats in KiwiJSchHelpers #932

sleberknight opened this issue Apr 10, 2023 · 0 comments · Fixed by #958
Assignees
@sleberknight
Labels
documentation Improvements or additions to documentation
Milestone
2.6.0

Comments

@sleberknight
Copy link
Member

KiwiJSchHelpers#detectKeyExchangeTypeForHost only supports a subset of the formats possible in known_hosts files. While we aren't going to fix this now (and have no plans to), we should at least document the limitations and the format(s) that are supported. We can provide a link to discussion #577 in the javadocs as additional background information.

See #577 for more background. This discussion was closed as Outdated (we don't need it anymore).
@sleberknight sleberknight added the documentation Improvements or additions to documentation label Apr 10, 2023
@sleberknight sleberknight self-assigned this Apr 22, 2023
@sleberknight sleberknight added this to the 2.6.0 milestone Apr 22, 2023
sleberknight added a commit that referenced this issue Apr 22, 2023
@sleberknight
KiwiJSchHelpers: Document known host format limitations, support IP
d60d268 
* Document the known_hosts hostname formats we support
* Add support for just IP address as a known_hosts hostname

Closes #932
Closes #957
@sleberknight sleberknight mentioned this issue Apr 22, 2023
Merged
chrisrohr pushed a commit that referenced this issue Apr 24, 2023
@sleberknight
KiwiJSchHelpers: Document known host format limitations, support IP (#…
17edd11 
…958)

* Document the known_hosts hostname formats we support
* Add support for just IP address as a known_hosts hostname

Closes #932
Closes #957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
2.6.0
Development

Successfully merging a pull request may close this issue.

KiwiJSchHelpers: Document known host format limitations, support IP kiwiproject/kiwi
1 participant
@sleberknight