Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add processHandleOfPid to KiwiEnvironment #943

Closed
sleberknight opened this issue Apr 17, 2023 · 0 comments · Fixed by #951
Closed

Add processHandleOfPid to KiwiEnvironment #943

sleberknight opened this issue Apr 17, 2023 · 0 comments · Fixed by #951
Assignees
@sleberknight
Labels
new feature A new feature such as a new class, method, package, group of classes, etc.
Milestone
2.6.0

Comments

@sleberknight
Copy link
Member

This complements the currentProcessHandle() method added in #919 to allow mocking out a ProcessHandle for a specific pid.

The method signature in KiwiEnvironment should be:

Optional<ProcessHandle> processHandleOfPid(long pid)

And the implementation in DefaultEnvironment can simply call the ProcessHandle.of(pid) method.

This originated from discussion #685 (Proposed KiwiEnvironment enhancements)
@sleberknight sleberknight added enhancement A request for change or improvement to an existing feature new feature A new feature such as a new class, method, package, group of classes, etc. and removed enhancement A request for change or improvement to an existing feature labels Apr 17, 2023
@sleberknight sleberknight self-assigned this Apr 22, 2023
@sleberknight sleberknight added this to the 2.6.0 milestone Apr 22, 2023
sleberknight added a commit that referenced this issue Apr 22, 2023
@sleberknight
Add processHandleOfPid to KiwiEnvironment and DefaultEnvironment
414aca7 
Closes #943
@sleberknight sleberknight mentioned this issue Apr 22, 2023
Merged
chrisrohr pushed a commit that referenced this issue Apr 24, 2023
@sleberknight
Add processHandleOfPid to KiwiEnvironment and DefaultEnvironment (#951)
64c5bb8 
Closes #943
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
new feature A new feature such as a new class, method, package, group of classes, etc.
Projects
None yet
Milestone
2.6.0
Development

Successfully merging a pull request may close this issue.

Add processHandleOfPid to KiwiEnvironment and DefaultEnvironment kiwiproject/kiwi
1 participant
@sleberknight