Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the javadocs more clear in KiwiReflection regarding member access #947

Closed
sleberknight opened this issue Apr 20, 2023 · 0 comments · Fixed by #967
Closed

Make the javadocs more clear in KiwiReflection regarding member access #947

sleberknight opened this issue Apr 20, 2023 · 0 comments · Fixed by #967
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@sleberknight
Copy link
Member

Some methods in KiwiReflection only find public members, while others attempt to find members (field, method, etc.) regardless of access modifier, and those methods typically call setAccessible(true) .

The javadocs on some methods make it clear whether it is finding any member, or only public ones. But the javadoc on other methods does not. This is to update the javadocs to make it clear for every method in this class what it does, i.e. does it only find public members? Does it find members regardless of access modifier? Does it call setAccessible(true), etc?

@sleberknight sleberknight added the documentation Improvements or additions to documentation label Apr 20, 2023
@sleberknight sleberknight self-assigned this Apr 25, 2023
@sleberknight sleberknight added this to the 2.6.0 milestone Apr 25, 2023
sleberknight added a commit that referenced this issue Apr 26, 2023
* Update javadoc for getFieldValue and setFieldValue with note that
  they call setAccessible on non-public methods
* Remove what can only be described as a incomplete thought on the
  javadoc of the setFieldValue which acceprs a Field

Closes  #947
sleberknight added a commit that referenced this issue Apr 26, 2023
#967)

* Update javadoc for getFieldValue and setFieldValue with note that
  they call setAccessible on non-public methods
* Remove what can only be described as a incomplete thought on the
  javadoc of the setFieldValue which acceprs a Field

Closes  #947
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant