Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KiwiReflection#findField should not make public Fields accessible #948

Closed
sleberknight opened this issue Apr 20, 2023 · 0 comments · Fixed by #953
Closed

KiwiReflection#findField should not make public Fields accessible #948

sleberknight opened this issue Apr 20, 2023 · 0 comments · Fixed by #953
Assignees
@sleberknight
Labels
enhancement A request for change or improvement to an existing feature
Milestone
2.6.0

Comments

@sleberknight
Copy link
Member

Since public fields are already accessible by any code, we can omit the call to setAccessible(true) in KiwiReflection#findField when the Field is already public.
@sleberknight sleberknight added the enhancement A request for change or improvement to an existing feature label Apr 20, 2023
sleberknight added a commit that referenced this issue Apr 22, 2023
@sleberknight
KiwiReflection#findField should only make non-public Fields accessible
3555662 
* Only call setAccessible(true) in findField if the Field is not public
  since public Fields are always accessible.

Closes #948
@sleberknight sleberknight mentioned this issue Apr 22, 2023
Merged
@sleberknight sleberknight added this to the 2.6.0 milestone Apr 22, 2023
@sleberknight sleberknight self-assigned this Apr 22, 2023
chrisrohr pushed a commit that referenced this issue Apr 24, 2023
@sleberknight
KiwiReflection#findField should only make non-public Fields accessible (
6becc50 
#953)

* Only call setAccessible(true) in findField if the Field is not public
  since public Fields are always accessible.

Closes #948
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
enhancement A request for change or improvement to an existing feature
Projects
None yet
Milestone
2.6.0
Development

Successfully merging a pull request may close this issue.

KiwiReflection#findField should only make non-public Fields accessible kiwiproject/kiwi
1 participant
@sleberknight