Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KiwiIO#newByteArrayInputStreamOfLines javadoc should mention it uses UTF-8 #997

Closed
sleberknight opened this issue Aug 1, 2023 · 0 comments · Fixed by #999
Closed

KiwiIO#newByteArrayInputStreamOfLines javadoc should mention it uses UTF-8 #997

sleberknight opened this issue Aug 1, 2023 · 0 comments · Fixed by #999
Assignees
@sleberknight
Labels
documentation Improvements or additions to documentation
Milestone
2.7.0

Comments

@sleberknight
Copy link
Member

The javadoc for KiwiIO#newByteArrayInputStreamOfLines should clearly state that internally it uses the UTF-8 Charset when getting the bytes of the joined String.
@sleberknight sleberknight added the documentation Improvements or additions to documentation label Aug 1, 2023
@sleberknight sleberknight added this to the 2.7.0 milestone Aug 1, 2023
@sleberknight sleberknight self-assigned this Aug 1, 2023
sleberknight added a commit that referenced this issue Aug 1, 2023
@sleberknight
Enhance KiwiIO#newByteArrayInputStreamOfLines javadoc
de8b7a6 
 The docs should mention that UTF-8 is used when converting to bytes.

Closes #997
@sleberknight sleberknight mentioned this issue Aug 1, 2023
Merged
dsingley pushed a commit that referenced this issue Aug 1, 2023
@sleberknight
Enhance KiwiIO#newByteArrayInputStreamOfLines javadoc (#999)
2443d6f 
The docs should mention that UTF-8 is used when converting to bytes.

Closes #997
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
2.7.0
Development

Successfully merging a pull request may close this issue.

Enhance KiwiIO#newByteArrayInputStreamOfLines javadoc kiwiproject/kiwi
1 participant
@sleberknight