Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add disableSniHostCheck property to TLS and SSL configuration classes #1086

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Add disableSniHostCheck property to TLS and SSL configuration classes #1086

merged 1 commit into from
Nov 25, 2023

Conversation

sleberknight
Copy link
Member

  • Add disableSniHostCheck to TlsContextConfiguration, SSLContextConfiguration, and SimpleSSLContextFactory
  • Update SSLContextConfiguration#toSimpleSSLContextFactory factory method to provide disableSniHostCheck to SimpleSSLContextFactory
  • Update SSLContextConfiguration#toTlsContextConfiguration factory method to provide disableSniHostCheck to TlsContextConfiguration
  • Update javadoc of the conversion functions in TlsContextConfiguration to explain how disableSniHostCheck is handled (since it does not exist in Dropwizard TlsConfiguration)
  • Update TlsContextConfiguration#toSslContextConfiguration to provide disableSniHostCheck to SSLContextConfiguration
  • Add new all-args constructor to SimpleSSLContextFactory
  • Clean up duplicative code in SimpleSSLContextFactory by extracting several private helper methods
  • Change SimpleSSLContextFactory#configuration method to be public, and to return unmodifiable map.
  • Change tests with lots of assertions to use assertAll
  • Minor grammatical fixes in javadocs and comments

Closes #1080
Closes #1085

@sleberknight
Add disableSniHostCheck property to TLS and SSL configuration classes
c99dc62 
* Add disableSniHostCheck to TlsContextConfiguration,
  SSLContextConfiguration, and SimpleSSLContextFactory
* Update SSLContextConfiguration#toSimpleSSLContextFactory factory
  method to provide disableSniHostCheck to SimpleSSLContextFactory
* Update SSLContextConfiguration#toTlsContextConfiguration factory
  method to provide disableSniHostCheck to TlsContextConfiguration
* Update javadoc of the conversion functions in TlsContextConfiguration
  to explain how disableSniHostCheck is handled (since it does
  not exist in Dropwizard TlsConfiguration)
* Update TlsContextConfiguration#toSslContextConfiguration to
  provide disableSniHostCheck to SSLContextConfiguration
* Add new all-args constructor to SimpleSSLContextFactory
* Clean up duplicative code in SimpleSSLContextFactory by extracting
  several private helper methods
* Change SimpleSSLContextFactory#configuration method to be
  public, and to return unmodifiable map.
* Change tests with lots of assertions to use assertAll
* Minor grammatical fixes in javadocs and comments

Closes #1080
Closes #1085
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@terezivy terezivy merged commit a133c0f into master Nov 25, 2023
7 checks passed
@terezivy terezivy deleted the 1080-add-disableSniHostCheck-option branch November 25, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terezivy terezivy terezivy approved these changes

@dsingley dsingley Awaiting requested review from dsingley

Assignees

@sleberknight sleberknight

@terezivy terezivy

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sleberknight @terezivy