Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide kiwi validation constraints via service loader mechanism #1113

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

sleberknight
Copy link
Member

  • Rename ValidationMessages.properties to ContributorValidationMessages.properties
  • Add jakarta.validation.ConstraintValidator in META-INF/services which defines the services that will be loaded via service loader
  • Remove the value in the validatedBy attribute of Constraint annotations on all kiwi custom constraints to avoid duplicate definitions of them.

Closes #1112

* Rename ValidationMessages.properties to
  ContributorValidationMessages.properties
* Add jakarta.validation.ConstraintValidator in META-INF/services
  which defines the services that will be loaded via service loader
* Remove the value in the validatedBy attribute of Constraint
  annotations on all kiwi custom constraints to avoid duplicate
  definitions of them.

Closes #1112
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sleberknight sleberknight merged commit 434719f into master Mar 10, 2024
5 checks passed
@sleberknight sleberknight deleted the 1112-use-service-loader-for-constraints branch March 10, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide kiwi validation constraints via service loader mechanism
4 participants