New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Javadocs and rename arguments in KiwiJars #1203

Merged

sleberknight merged 1 commit into main from 1198-clarify-KiwiJars-gets-main-attributes

Sep 19, 2024

Member

sleberknight commented Sep 19, 2024

Rename method arguments and update Javadocs to make it clear the methods are only finding main attributes of a JAR.
While it would be nice to rename the methods too, decided against this as it would cause a major version change.

Closes #1198


          Update Javadocs and rename arguments in KiwiJars

7c8254d

* Rename method arguments and update Javadocs to make it clear the
  methods are only finding main attributes of a JAR.
* While it would be nice to rename the methods too, decided against
  this as it would cause a major version change.

Closes #1198

sleberknight self-assigned this

sonarqubecloud bot commented Sep 19, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sleberknight merged commit c1eebfa into main

5 checks passed

sleberknight deleted the 1198-clarify-KiwiJars-gets-main-attributes branch

September 19, 2024 22:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet