Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overloaded readAllMainAttributesFromJarManifest methods to KiwiJars #1204

Conversation

sleberknight
Copy link
Member

  • Add 3 overloaded methods named readAllMainAttributesFromJarManifest which provide an easier way to get all main attributes from a JAR manifest. Since these are new methods, I named them to make it clear what they are getting from the manifest, at the expense of inconsistency with the existing method names.
  • Changed a log message to make it clearer when a specific main attribute could not be found in a JAR manifest.
  • A few minor Javadoc changes to add a space in the generic type declaration.

* Add 3 overloaded methods named readAllMainAttributesFromJarManifest
  which provide an easier way to get all main attributes from
  a JAR manifest. Since these are new methods, I named them to
  make it clear what they are getting from the manifest, at the
  expense of inconsistency with the existing method names.
* Changed a log message to make it clearer when a specific
  main attribute could not be found in a JAR manifest.
* A few minor Javadoc changes to add a space in the generic
  type declaration.
@sleberknight sleberknight added the new feature A new feature such as a new class, method, package, group of classes, etc. label Oct 12, 2024
@sleberknight sleberknight added this to the 4.5.0 milestone Oct 12, 2024
@sleberknight sleberknight self-assigned this Oct 12, 2024
Copy link

sonarcloud bot commented Oct 12, 2024

@sleberknight sleberknight merged commit 379d95d into main Oct 12, 2024
5 checks passed
@sleberknight sleberknight deleted the add-new-KiwiJars-methods-to-get-all-main-attrs-from-manifest branch October 12, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature A new feature such as a new class, method, package, group of classes, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant