Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates and miscellaneous changes in KiwiPreconditions #474

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

sleberknight
Copy link
Member

  • Fix a few typos in some of the docs that used "and" instead of "an"
  • Add exception information to the checkEvenItemCount method javadocs
  • Change the checkEvenItemCount methods to use the requireNotNull
    from KiwiPreconditions instead of Objects#requireNonNull so that it
    throws IllegalArgumentException instead of NullPointerException
  • IntelliJ decided to reformat some other javadocs which apparently
    must have had a tab character in them
  • Add DisplayName annotation to KiwiPreconditionsTest, though I'm not
    quite ready to restructure the original tests to use nested structure

* Fix a few typos in some of the docs that used "and" instead of "an"
* Add exception information to the checkEvenItemCount method javadocs
* Change the checkEvenItemCount methods to use the requireNotNull
  from KiwiPreconditions instead of Objects#requireNonNull so that it
  throws IllegalArgumentException instead of NullPointerException
* IntelliJ decided to reformat some other javadocs which apparently
  must have had a tab character in them
* Add DisplayName annotation to KiwiPreconditionsTest, though I'm not
  quite ready to restructure the original tests to use nested structure
@sleberknight sleberknight added the documentation Improvements or additions to documentation label Dec 7, 2020
@sleberknight sleberknight added this to the 0.18.0 milestone Dec 7, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@chrisrohr chrisrohr merged commit 5dba87e into master Dec 7, 2020
@chrisrohr chrisrohr deleted the doc-updates-and-fixes-in-KiwiPreconditions branch December 7, 2020 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants