Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sonar java:S6068 (simplify Mockito usage) #499

Merged
merged 2 commits into from
Jan 31, 2021
Merged

Fix Sonar java:S6068 (simplify Mockito usage) #499

merged 2 commits into from
Jan 31, 2021

Conversation

sleberknight
Copy link
Member

  • Remove extraneous calls to eq() in tests
  • Add logging in TimeBasedDirectoryCleanerConfigTest on termination
    of ExecutorService

@sleberknight
Fix Sonar java:S6068 (simplify Mockito usage)
ab13c72 
* Remove extraneous calls to eq() in tests
* Add logging in TimeBasedDirectoryCleanerConfigTest on termination
  of ExecutorService
@sleberknight sleberknight added the code cleanup Fix issues reported by Sonar or any other code analysis tools label Jan 30, 2021
@sleberknight sleberknight added this to the 0.19.0 milestone Jan 30, 2021
@sleberknight sleberknight marked this pull request as draft January 30, 2021 21:51
@sleberknight sleberknight marked this pull request as ready for review January 30, 2021 21:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chrisrohr chrisrohr merged commit deb92fa into master Jan 31, 2021
@chrisrohr chrisrohr deleted the fix-sonar-java_S6068 branch January 31, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisrohr chrisrohr chrisrohr approved these changes

Assignees

@chrisrohr chrisrohr

Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sleberknight @chrisrohr