Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IntValue validation annotation #508

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Add IntValue validation annotation #508

merged 2 commits into from
Feb 18, 2021

Conversation

sleberknight
Copy link
Member

Closes #506

@sleberknight
Copy link
Member Author

@chrisrohr As I just started on the @Long one, I wondered if it is confusing to have these named the same thing as Java's primitive int and long, and also @Long clashes with java.lang.Long. Would it be better to rename them?
e.g. @IntValue or @ConvertibleToInt or @IntConvertible or something like that?

@sleberknight sleberknight marked this pull request as draft February 18, 2021 22:45
@sleberknight sleberknight changed the title Add Int validation annotation Add IntValue validation annotation Feb 18, 2021
@sleberknight sleberknight marked this pull request as ready for review February 18, 2021 23:15
@sleberknight
Copy link
Member Author

I decided to rename to @IntValue (and the long one will be @LongValue) so as to avoid conflicts with Java primitive and/or class names.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@chrisrohr chrisrohr merged commit cf36598 into master Feb 18, 2021
@chrisrohr chrisrohr deleted the 506-Int-validation-annotation branch February 18, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisrohr chrisrohr chrisrohr approved these changes

Assignees

@chrisrohr chrisrohr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add @IntValue validation annotation
2 participants
@sleberknight @chrisrohr