Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup build for Java 11 and 16 #546

Merged
merged 4 commits into from
Apr 14, 2021
Merged

Setup build for Java 11 and 16 #546

merged 4 commits into from
Apr 14, 2021

Conversation

chrisrohr
Copy link
Contributor

  • Project will compile on all versions
  • Tests only will be run on 16
  • Tests, Jacoco and Sonar will run on 11

* Project will compile on all versions
* Tests only will be run on 16
* Tests, Jacoco and Sonar will run on 11
@chrisrohr chrisrohr added the enhancement A request for change or improvement to an existing feature label Apr 13, 2021
@chrisrohr chrisrohr added this to the 0.23.0 milestone Apr 13, 2021
@chrisrohr chrisrohr requested a review from sleberknight April 13, 2021 20:14
Copy link
Member

@sleberknight sleberknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions...apply if you think they make sense. (I was afraid they might be overkill)

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@sleberknight
Copy link
Member

Wait...just checked the build output, and the tests ran on both JDK 11 and 16

chrisrohr and others added 3 commits April 13, 2021 21:26
Co-authored-by: Scott Leberknight <174812+sleberknight@users.noreply.github.com>
Co-authored-by: Scott Leberknight <174812+sleberknight@users.noreply.github.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chrisrohr chrisrohr merged commit 66e6aeb into master Apr 14, 2021
@chrisrohr chrisrohr deleted the support-jdk-16 branch April 14, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A request for change or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants