Improve version comparison when number of version segments is different #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make entire version comparison case-insensitive * Update Versions#versionCompare to handle cases in which versions contain things like SNAPSHOT, alpha1, beta3, M1 etc. * Extract some methods to keep versionCompare relatively clean * Revise javadocs for Versions#versionCompare * Add a bunch of additional test expectations with versions from libraries we use such as Guava, Spring (w/ RELEASE naming convention), Jetty (old convention with yyyymmdd), JUnit with M1, M2, etc. as well as a bunch of other commonly seen situations that ought to cover the majority of real-world situations. Closes #45
|
Kudos, SonarCloud Quality Gate passed! |
chrisrohr
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contain things like SNAPSHOT, alpha1, beta3, M1 etc.
libraries we use such as Guava, Spring (w/ RELEASE naming convention),
Jetty (old convention with yyyymmdd), JUnit with M1, M2, etc. as well
as a bunch of other commonly seen situations that ought to cover the
majority of real-world situations.
Closes #45