Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable testScheduleCleanup_WithScheduledExecutor_UsingMultipleConcurrentCleaners_IntegrationTest on all platforms #554

Merged
merged 2 commits into from
Apr 22, 2021

Conversation

chrisrohr
Copy link
Contributor

@chrisrohr chrisrohr commented Apr 21, 2021

The concurrent cleaners need to be created with a small buffer in between. See #143 for details

Fixes #143

…urrentCleaners_IntegrationTest on all platforms

The concurrent cleaners need to be created with a small buffer in between.  See #143 for details

Fixes #143
@chrisrohr chrisrohr requested a review from sleberknight April 21, 2021 01:30
@chrisrohr chrisrohr changed the title Re-enable testScheduleCleanup_WithScheduledExecutor_UsingMultipleConc… Re-enable testScheduleCleanup_WithScheduledExecutor_UsingMultipleConcurrentCleaners_IntegrationTest on all platforms Apr 21, 2021
Copy link
Member

@sleberknight sleberknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@chrisrohr chrisrohr requested a review from sleberknight April 22, 2021 11:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sleberknight sleberknight merged commit 0bb5365 into master Apr 22, 2021
@sleberknight sleberknight deleted the 143-fix-test-on-mac branch April 22, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate why TimeBasedDirectoryCleaner counts too many deletes on MacOS
2 participants