Refactor TimeBasedDirectoryCleanerConfigTest for macOS vs Linux #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the concurrent test in TimeBasedDirectoryCleanerConfigTest so that it uses '>=' instead of '==' on macOS when waiting for number of deletions and when making assertions about the total delete count. This accommodates (though certainly doesn't explain) the behavior we see on macOS in which there are more successful deletions than there are files created. On Linux (CentOS as well as Ubuntu) we have never seen that behavior, so for those OSes we retain the strict equality check. Relates to #143 (which is already closed)
sleberknight
added
the
code cleanup
chrisrohr
approved these changes
May 4, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
sleberknight
deleted the
143-TimeBasedDirectoryCleanerConfigTest-add-separate-macOS-conditions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the concurrent test in TimeBasedDirectoryCleanerConfigTest so
that it uses '>=' instead of '==' on macOS when waiting for number of
deletions and when making assertions about the total delete count. This
accommodates (though certainly doesn't explain) the behavior we see on
macOS in which there are more successful deletions than there are files
created. On Linux (CentOS as well as Ubuntu) we have never seen that
behavior, so for those OSes we retain the strict equality check.
Relates to #143 (which is already closed)