Support generics in WebTargetHelper (BREAKING API CHANGES) #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace queryParams(Map) with queryParamsFromMap * Replace queryParams(MultivaluedMap) with queryParamsFromMultivaluedMap * Make both of the above methods accept a map with String keys and values of type V * Re-organize tests in WebTargetHelperTest; since the two methods now have distinct names, move each nested test class to the top level and rename accordingly. * Wrote lots of implementation notes and other code comments explaining why the methods are now named differently, and also why I had to insert that nasty cast in the queryParamsFromMultivaluedMap method. Closes #570
|
Kudos, SonarCloud Quality Gate passed! |
chrisrohr
approved these changes
May 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
values of type V
have distinct names, move each nested test class to the top level
and rename accordingly.
why the methods are now named differently, and also why I had to
insert that nasty cast in the queryParamsFromMultivaluedMap method.
Closes #570