Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that KiwiUrls#toQueryString does not perform encoding #616

Merged
merged 1 commit into from
Oct 25, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/main/java/org/kiwiproject/net/KiwiUrls.java
Original file line number Diff line number Diff line change
Expand Up @@ -592,8 +592,11 @@ public static Map<String, String> queryStringToMap(String queryString) {
}

/**
* Converts a Map of String of Strings into one (potentially long) string of key/value parameters (each key/value
* parameter is separated by an '=' character), with each parameter pair separated by an '&amp;' character.
* Converts a Map containing String keys and values into one (potentially long) string of key/value parameters
* (each key/value parameter is separated by an '=' character), with each parameter pair separated by an '&amp;'
* character.
* <p>
* Note specifically that this method does <strong>not</strong> URL encode the parameters.
*
* @param parameters the map of the parameters to create the query string from
* @return a concatenated query string
Expand Down