Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KiwiThrowables improvements and new features in ThrowableInfo #719

Merged
merged 1 commit into from
May 3, 2022

Conversation

sleberknight
Copy link
Member

  • Add @nullable annotation to method parameters that can be null
  • Improve/add Javadocs to existing methods in ThrowableInfo
  • Add emptyThrowableInfo() method which always returns the same
    singleton "empty" ThrowableInfo instance
  • Always return the singleton "empty" instance from ThrowableInfo#of
    when given a null Throwable as the argument
  • Add isEmptyInstance() method to ThrowableInfo to permit calling code
    to determine whether the original Throwable was null
  • Add hasCause() to ThrowableInfo to allow easy checking whether the
    original Throwable had a cause (if not null)
  • Add tests for new methods and more assertions in some existing tests

* Add @nullable annotation to method parameters that can be null
* Improve/add Javadocs to existing methods in ThrowableInfo
* Add emptyThrowableInfo() method which always returns the same
  singleton "empty" ThrowableInfo instance
* Always return the singleton "empty" instance from ThrowableInfo#of
  when given a null Throwable as the argument
* Add isEmptyInstance() method to ThrowableInfo to permit calling code
  to determine whether the original Throwable was null
* Add hasCause() to ThrowableInfo to allow easy checking whether the
  original Throwable had a cause (if not null)
* Add tests for new methods and more assertions in some existing tests
@sleberknight sleberknight added the enhancement A request for change or improvement to an existing feature label Apr 30, 2022
@sleberknight sleberknight requested a review from chrisrohr April 30, 2022 20:25
@sleberknight sleberknight added this to the 2.1.0 milestone Apr 30, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@chrisrohr chrisrohr merged commit a52f3af into master May 3, 2022
@chrisrohr chrisrohr deleted the KiwiThrowable-improvements branch May 3, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A request for change or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants