Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeQL: Fix "Log Injection" in RangeValidator #897

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

sleberknight
Copy link
Member

In logWarning, simply log the type of the object instead of the (user-entered) value. This provides less information, but avoids the log injection problem.

Fixes #881
Fixes #882

In logWarning, simply log the type of the object instead of the (user-entered) value.
This provides less information, but avoids the log injection problem.

Fixes #881
Fixes #882
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@sleberknight sleberknight merged commit 81b75bb into master Jan 31, 2023
@sleberknight sleberknight deleted the codeql-fix-Log-Injection-in-RangeValidator branch January 31, 2023 18:57
sleberknight added a commit that referenced this pull request Jan 31, 2023
In logWarning, simply log the type of the object instead of the (user-entered) value.
This provides less information, but avoids the log injection problem.

Fixes #881
Fixes #882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - Log Injection Fix code scanning alert - Log Injection
3 participants