Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to post release to GitHub #33

Closed
sleberknight opened this issue May 29, 2023 · 2 comments · Fixed by #157, #160 or #161
Closed

Option to post release to GitHub #33

sleberknight opened this issue May 29, 2023 · 2 comments · Fixed by #157, #160 or #161
Assignees
@sleberknight
Labels
enhancement A request for change or improvement to an existing feature
Milestone
0.8.0

Comments

@sleberknight
Copy link
Member

sleberknight commented May 29, 2023 •
edited
Loading

This would generate the release notes and post them to GitHub.

It should be available in the configuration file (see #31) as well as an option in interactive mode (see #32).
@sleberknight sleberknight added the enhancement A request for change or improvement to an existing feature label May 29, 2023
@sleberknight
Copy link
Member Author

Probably only provide GitHub initially, since that's where all our repos currently live.

@sleberknight sleberknight changed the title Option to post release to GitHub or GitLab Option to post release to GitHub May 1, 2024
@sleberknight sleberknight pinned this issue May 5, 2024
@sleberknight sleberknight added this to the 0.8.0 milestone May 14, 2024
@sleberknight
Copy link
Member Author

Probably only provide GitHub initially, since that's where all our repos currently live.

Especially since we removed GitLab support in #130 🤪

sleberknight added a commit that referenced this issue May 26, 2024
@sleberknight
Preparation and refactoring for creating releases
a527436 
This commit refactors existing code and does some
preparation work to make creating new releases
easier. Mostly this involves adding a 'post' method
to GithubApi and refactoring common GitHub request
and response processing code.

Details:

* Refactor GithubApi by extracting common GitHub REST
  API code, renaming Response to GitHubResponse and
  adding more properties, and adding a new #post method.
* Add a companion object to GitHubResponse to allow
  easy creation from an HttpResponse.
* Add several extension methods for HttpHeaders in
  HttpHeadersExtensions.kt.
* Add response check to GithubListFetcher, since the
  GithubApi no longer throws an exception when it
  gets an unsuccessful status code.

Related to #33
@sleberknight sleberknight mentioned this issue May 26, 2024
Merged
sleberknight added a commit that referenced this issue May 26, 2024
@sleberknight
Preparation and refactoring for creating releases (#157)
0f2785d 
This commit refactors existing code and does some
preparation work to make creating new releases
easier. Mostly this involves adding a 'post' method
to GithubApi and refactoring common GitHub request
and response processing code.

Details:

* Refactor GithubApi by extracting common GitHub REST
  API code, renaming Response to GitHubResponse and
  adding more properties, and adding a new #post method.
* Add a companion object to GitHubResponse to allow
  easy creation from an HttpResponse.
* Add several extension methods for HttpHeaders in
  HttpHeadersExtensions.kt.
* Add response check to GithubListFetcher, since the
  GithubApi no longer throws an exception when it
  gets an unsuccessful status code.

Related to #33
@sleberknight sleberknight linked a pull request May 26, 2024 that will close this issue
Preparation and refactoring for creating releases #157
Merged
sleberknight added a commit that referenced this issue May 27, 2024
@sleberknight
Preparation and refactoring for creating releases
207dcc6 
This commit adds the GitHubReleaseManager class with
a method for creating new releases in GitHub.

For the test, it uses the MockWebServer from OkHttp.

Related to #33
@sleberknight sleberknight mentioned this issue May 27, 2024
Merged
sleberknight added a commit that referenced this issue May 27, 2024
@sleberknight
Preparation and refactoring for creating releases
4449ff1 
This commit adds the GitHubReleaseManager class with
a method for creating new releases in GitHub.

For the test, it uses the MockWebServer from OkHttp.

Related to #33
sleberknight added a commit that referenced this issue May 27, 2024
@sleberknight
Preparation and refactoring for creating releases (#160)
da6cc56 
This commit adds the GitHubReleaseManager class with
a method for creating new releases in GitHub.

For the test, it uses the MockWebServer from OkHttp.

Related to #33
@sleberknight sleberknight linked a pull request May 27, 2024 that will close this issue
Preparation and refactoring for creating releases #160
Merged
@sleberknight sleberknight self-assigned this May 27, 2024
sleberknight added a commit that referenced this issue May 27, 2024
@sleberknight
Implement GitHub release creation
1332167 
This commit implements GitHub releases in GenerateChangelog
when the output type is GITHUB.

It also fixes a bug from the previous commit, in which
the URL to get a tag was incorrect.

Misc:

* Extracted writeChangeLog and writeFile methods to allow
  for unit testing the releases.
* Add a companion object to CategoryConfig with an "empty"
  factory method. This was mainly to make the unit tests
  a little nicer.

Closes #33
@sleberknight sleberknight mentioned this issue May 27, 2024
Merged
sleberknight added a commit that referenced this issue May 28, 2024
@sleberknight
Implement GitHub release creation (#161)
7d745dd 
This commit implements GitHub releases in GenerateChangelog
when the output type is GITHUB.

It also fixes a bug from the previous commit, in which
the URL to get a tag was incorrect.

Misc:

* Extracted writeChangeLog and writeFile methods to allow
  for unit testing the releases.
* Add a companion object to CategoryConfig with an "empty"
  factory method. This was mainly to make the unit tests
  a little nicer.

Closes #33
@sleberknight sleberknight unpinned this issue May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
enhancement A request for change or improvement to an existing feature
Projects
None yet
Milestone
0.8.0
1 participant
@sleberknight